[CIS-3 NFT] Fix nonce event serialization #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lassemoldrup
changed the title
DOBEN
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
can you apply these changes to:
cis2-multicontract as well (implements the CIS3 standard).
Consider changing the order of the fields in the NonceEvent in the cis5-smart-contract-wallet (we haven't formally defined the standard yet, but keeping consistency in the NonceEvent seems meaningful across the contracts).
Bargsteen
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
As per the CIS-3 specification, nonce events should be serialized with the
noncefirst, followed by theaccount. This is currently not the case.